pedro/DiveSim
1
0
Fork 0
Code Issues 74 Pull requests Projects Releases 1 Packages Wiki Activity Actions

[P3] Dive time freezes after re-descending without applying a surface interval #35

New issue
Closed
opened 2026-10-27 02:59:42 +00:00 by pedro · 1 comment
pedro commented 2026-10-27 02:59:42 +00:00
Owner
Copy link

Priority: P3
Type: bug
Source: project review requested 2026-10-26 (second pass)

Location: src/surfaceInterval.ts:68-80

Problem and evidence

currentDiveMinutes measures from the first departure after the last recorded interval to the first surfacing after it. Surfacing and descending again without applying an interval keeps the readout at the first dive's runtime: 20 m for 11 min, surface, 3 min at the surface, 10 m for 5 min shows 13.22 throughout.

Suggested correction

Measure from the most recent departure from the surface in history, consistent with the documented freeze-on-surfacing and reset-after-interval behaviour.

Acceptance criteria

Regression for re-descent without an interval and existing interval behaviour; pnpm verify passes.

Scope: maintenance of the educational simulator. Preserve historical R1 acceptance and operational-validation limits.

Priority: P3 Type: bug Source: project review requested 2026-10-26 (second pass) Location: `src/surfaceInterval.ts:68-80` Problem and evidence currentDiveMinutes measures from the first departure after the last recorded interval to the first surfacing after it. Surfacing and descending again without applying an interval keeps the readout at the first dive's runtime: 20 m for 11 min, surface, 3 min at the surface, 10 m for 5 min shows 13.22 throughout. Suggested correction Measure from the most recent departure from the surface in history, consistent with the documented freeze-on-surfacing and reset-after-interval behaviour. Acceptance criteria Regression for re-descent without an interval and existing interval behaviour; pnpm verify passes. Scope: maintenance of the educational simulator. Preserve historical R1 acceptance and operational-validation limits.
pedro commented 2026-10-27 04:16:30 +00:00
Author
Owner
Copy link

Fixed on maintenance/review-2026-10-27 in 433b8ac — PR #40.

Dive time measures from the latest surface departure. B/C/VPM regression; README updated.

Branch verification: pnpm verify 145 tests and release budgets; Chromium/Firefox/WebKit review, replay, compatibility and offline lifecycle checks; CI verify runs #111/#112 pass. Record: docs/MAINTENANCE-2026-10-27.md. Closes on merge of PR #40.

Fixed on `maintenance/review-2026-10-27` in `433b8ac` — [PR #40](https://git.guresky.com/pedro/DiveSim/pulls/40). Dive time measures from the latest surface departure. B/C/VPM regression; README updated. Branch verification: `pnpm verify` 145 tests and release budgets; Chromium/Firefox/WebKit review, replay, compatibility and offline lifecycle checks; CI verify runs #111/#112 pass. Record: `docs/MAINTENANCE-2026-10-27.md`. Closes on merge of PR #40.
pedro closed this issue 2026-10-27 05:39:05 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
t3/project-branding-style-guide
maintenance/review-2026-10-27
codex/release-r1
R1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pedro/DiveSim#35
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?